Skip to content

Build mode #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 69 commits into from
Aug 21, 2025
Merged

Build mode #1484

merged 69 commits into from
Aug 21, 2025

Conversation

sheetalkamat
Copy link
Member

No description provided.

@sheetalkamat sheetalkamat force-pushed the buildMode branch 8 times, most recently from a8171c9 to 761ddba Compare August 1, 2025 18:49
@sheetalkamat sheetalkamat mentioned this pull request Aug 1, 2025
Closed
@sheetalkamat sheetalkamat force-pushed the buildMode branch 5 times, most recently from fe6b422 to 356238c Compare August 4, 2025 23:39
@sheetalkamat sheetalkamat mentioned this pull request Aug 5, 2025
Merged
@sheetalkamat sheetalkamat force-pushed the buildMode branch 4 times, most recently from b13fcfc to f7c042c Compare August 5, 2025 23:03
@sheetalkamat sheetalkamat force-pushed the buildMode branch 9 times, most recently from f435b34 to 13ee154 Compare August 15, 2025 03:29
@sheetalkamat sheetalkamat mentioned this pull request Aug 15, 2025
Merged
@sheetalkamat
Copy link
Member Author

Refactoring further into two sub packages build and tsc so its easier to look at files

@sheetalkamat sheetalkamat mentioned this pull request Aug 21, 2025
Merged
Copilot
Copilot AI reviewed Aug 21, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@jakebailey jakebailey requested a review from Copilot August 21, 2025 17:13
@sheetalkamat
Copy link
Member Author

Looking into race

andrewbranch
andrewbranch approved these changes Aug 21, 2025
View reviewed changes
Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like some explanatory comments in execute would be helpful, but I don't see anything concerning here. Tried it out on arethetypeswrong and it's 4.5x faster :)

jakebailey
jakebailey approved these changes Aug 21, 2025
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy to report straight up 10x on dt-tools 😄

image

@sheetalkamat sheetalkamat added this pull request to the merge queue Aug 21, 2025
Merged via the queue into main with commit 7fbbe04 Aug 21, 2025
22 checks passed
@sheetalkamat sheetalkamat deleted the buildMode branch August 21, 2025 23:45
This was referenced Aug 21, 2025
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

@jakebailey jakebailey jakebailey approved these changes

Copilot code review Copilot Awaiting requested review from Copilot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sheetalkamat @andrewbranch @jakebailey